Add support for source links on GitHub enterprise instances #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciccarello
reviewed
Aug 23, 2018
|
I had a look at writing some tests, and can get one that would test that it defaults to import * as github from './../lib/converter/plugins/GitHubPlugin';
import Assert = require('assert');
describe('GitHubRepository', function() {
let repository = new github.Repository('', '');
describe('contructor', function() {
it('must default to github.com hostname', function() {
Assert.equal(repository.gitHubHostname, 'github.com');
});
});
});Any ideas @aciccarello ? |
added 3 commits
August 23, 2018 20:12
Needed for better unit testing
Allows us to more easily unit test the class by passing in an array of strings
|
I figured it out, with a small refactor. Should be good to go @aciccarello! |
|
@aciccarello Any thoughts on this? Thanks! |
|
Sorry for not following up on this @tomratcliffe. I'm hoping to look at it this week. |
|
Thanks for your contribution @tomratcliffe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for GitHub Enterprise source URLs found in the list of
git ls-remote --get-url.The updated regex checks for URLs like
github.acme.cominstead of justgithub.aaakk.us.kg, and then uses the matched hostname when generating the source URLs.I didn't add any tests for this as I'm not sure what your testing strategy is/I couldn't find a testing file for just this module. Happy to try and add this in though if required!
Should be backwards compatible with old URLs.
Fixes #249, which was closed in favour of #129.
This doesn't entirely solve #129, but closes the gap on allowing GHE to work out of the box.